Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Revert "Add supportTaskTypes for agentservice without write it in config twice." #412

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Revert "Add supportTaskTypes for agentservice without write it in config twice." #412

merged 1 commit into from
Oct 4, 2023

Conversation

Future-Outlier
Copy link
Member

Reverts #398

@Future-Outlier
Revert "Add supportTaskTypes for agentservice without write it in con…
1fd95a1 
…fig twice. (flyteorg#398)"

This reverts commit 2598c96.

Signed-off-by: Future Outlier <[email protected]>
@Future-Outlier Future-Outlier force-pushed the revert-398-add-supportedTaskTypes-for-agent-service-by-default-for-task-types branch from 4dc7f57 to 1fd95a1 Compare October 3, 2023 02:57
@Future-Outlier Future-Outlier mentioned this pull request Oct 3, 2023
Open
8 tasks
@pingsutw pingsutw requested a review from honnix October 3, 2023 03:39
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (445fc58) 62.86% compared to head (3f5a76c) 64.19%.

❗ Current head 3f5a76c differs from pull request most recent head 1fd95a1. Consider uploading reports for the commit 1fd95a1 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
+ Coverage   62.86%   64.19%   +1.32%     
==========================================
  Files         156      156              
  Lines       13201    10704    -2497     
==========================================
- Hits         8299     6871    -1428     
+ Misses       4271     3202    -1069     
  Partials      631      631
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
go/tasks/plugins/webapi/agent/config.go 100.00% <ø> (ø)
go/tasks/plugins/webapi/agent/plugin.go 68.53% <50.00%> (+2.48%) ⬆️

... and 136 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Future-Outlier Future-Outlier mentioned this pull request Oct 3, 2023
Merged
3 tasks
@pingsutw pingsutw merged commit e4ece18 into flyteorg:master Oct 4, 2023
5 of 7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@honnix honnix honnix approved these changes

@hamersaw hamersaw hamersaw approved these changes

@pingsutw pingsutw pingsutw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Future-Outlier @honnix @hamersaw @pingsutw